[PATCH] fix usage of dbus_error_is_set in libhal

John (J5) Palmieri johnp at redhat.com
Tue Nov 7 08:36:35 PST 2006


On Tue, 2006-11-07 at 00:18 +0100, Danny Kukawka wrote:
> Hi,
> 
> this patch fixes the usage of dbus_error_is_set(error) if the error is NULL. 
> Added check to be sure the lib don't call dbus_error_is_set() if the error is 
> NULL, otherwise the call crash.
> 
> Cheers,
> 
> Danny
> 
>  libhal.c | 40 ++++++++++++++++++++--------------------
>  1 file changed, 20 insertions(+), 20 deletions(-)

While accepting NULL for an error argument is acceptable for user code I
personally think it is pretty wrong for internal modules to be ignoring
the specific errors returned.  At the least they should log them.  This
patch sort of peppers over the issues in a pretty important system
daemon.

-- 
John (J5) Palmieri <johnp at redhat.com>



More information about the hal mailing list