[patch] Detecting batteries - need small change

David Zeuthen david at fubar.dk
Tue Oct 10 12:01:45 PDT 2006


On Tue, 2006-10-10 at 19:58 +0100, Richard Hughes wrote:
> On Tue, 2006-10-10 at 14:44 -0400, David Zeuthen wrote:
> > On Sat, 2006-09-23 at 14:20 +0100, Richard Hughes wrote:
> > > Good to commit?
> > 
> > Yes, but please use "goto" rather than returning in the middle of the
> > function (which in my book is bad style). Thanks.
> 
> I've changed it to use goto and committed this. Many thanks.

Thanks. In the future please adhere to the rules we have for commit
messages, see file HACKING, e.g. don't start the first line with a
capital letter.

     David




More information about the hal mailing list