[PATCH] FDI fixes for newer MacBookPro models

[Doug Goldstein]

Danny Kukawka wrote:
> On Mittwoch, 18. April 2007, Martin Pitt wrote:
>   
>> Hi,
>>
>> Matthew recently fixed the FDIs to support newer MacBook Pro models.
>>
>> Patch applies cleanly to 0.5.9 and git head.
>>
>> Thanks for considering,
>>     
>
> 1) smbios.system.product is deprecated use system.hardware.product
>    instead
> 2) Wouldn't it make sense to check simply if system.hardware.product
>    contains MacBookPro as string? See attached patch.
>
> Danny
>
>  10-macbookpro-utils.fdi |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
>
>   
> ------------------------------------------------------------------------
>
> diff --git a/fdi/policy/10osvendor/10-macbookpro-utils.fdi b/fdi/policy/10osvendor/10-macbookpro-utils.fdi
> index 1b0ac67..39aaddf 100644
> --- a/fdi/policy/10osvendor/10-macbookpro-utils.fdi
> +++ b/fdi/policy/10osvendor/10-macbookpro-utils.fdi
> @@ -6,7 +6,7 @@
>    <device>
>      <match key="system.kernel.name" string="Linux">
>        <match key="system.hardware.vendor" string="Apple Computer, Inc.">
> -        <match key="system.hardware.product" string="MacBookPro1,1">
> +        <match key="system.hardware.product" string="MacBookPro">
>            <spawn udi="/org/freedesktop/Hal/devices/macbook_pro_light_sensor"/>
>            <spawn udi="/org/freedesktop/Hal/devices/macbook_pro_keyboard_backlight"/>
>            <spawn udi="/org/freedesktop/Hal/devices/macbook_pro_lcd_panel"/>
>   
> ------------------------------------------------------------------------
>
> _______________________________________________
> hal mailing list
> hal at lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/hal
>   
Doesn't that need to be contains? That's at least what I did on Gentoo a
few weeks back.