[PATCH] fix broken logic for system.formfactor=laptop
danny.kukawka at web.de
Thu Aug 23 13:04:39 PDT 2007
On Dienstag, 14. August 2007, Danny Kukawka wrote:
> Now I would propose to fix the problem for the ACPI case
> by check for a battery bay or a lid button in /proc/acpi/*. I think we can
> may ignore the APM case for the moment.
> For this I changed acpi_synthesize() a little bit to let the function run
> without synthesize ACPI devices because this function already check if the
> machine is a laptop.
> In computer_probing_helper_done() HAL check now if system.formfactor isn't
> set or not 'laptop' and calls acpi_check_is_laptop() in this case, to do
> the needed checks. If there is a complete and working ACPI implementation
> in sysfs in the future we need to do something similar.
After discussion with Richard in IRC: commited with a litte change.
More information about the hal