[PATCH] fix changeset handling for HAL_PROPERTY_TYPE_STRLIST
davidz at redhat.com
Tue Aug 28 09:32:48 PDT 2007
On Wed, 2007-08-22 at 20:18 +0200, Danny Kukawka wrote:
> this patch fixes some problems with the workflow and signal handling in
> changesets via libhal for HAL_PROPERTY_TYPE_STRLIST:
> * If libhal_changeset_set_property_strlist() get currently used to add a
> stringlist to HAL after call libhal_device_commit_changeset() for each
> new entry of the list a 'PROPERTY_CHANGED' signal get emitted.
> This seems to be wrong and make also no sence because you can't find
> out what in the list was changed/added, since the signals get emitted
> after the commit call where the list is already complete changed.
> I changed this to commit the signal only one for each call of
> * If libhal_changeset_set_property_strlist() get currently used in the
> code HAL use hal_device_property_strlist_clear() to clear the list for
> the new list. This function also call hal_property_strlist_clear() which
> doesn't work (which we already detected in March 2007) and cause some
> times later a crash in HAL. I fixed this by remove the strlist property
> from the hashtable and add an new empty property instead with the same
This sounds like a reasonable and nice fix. Please commit, thanks.
More information about the hal