[PATCH] Remove checking for run-time usb.ids and pci.ids at build time

Danny Kukawka danny.kukawka at web.de
Thu Feb 1 10:29:11 PST 2007


On Thursday 01 February 2007 18:56, David Zeuthen wrote:
> On Thu, 2007-02-01 at 01:20 +0000, Rob Taylor wrote:
> > 2nd time lucky..
> >
> > Remove build time checking for location of usb.ids and pci.ids. Adds new
> > configure flags --with-pci-ids and --with-usb-ids for specifying
> > locations of pci.ids and usb.ids respectivly. Also adds
> > --disable-pci-ids, --disable-usb-ids and --disable-pnp-ids.
>
> Looks good to me. Thanks!

No, it doesn't look good. You can't now run autogen.sh without add the path to 
the id-files. Since this is used IMO on the most linux systems (maybe exclude 
the embedded stuff) there should be a automatic detection of this files as 
before. 

I can accept a way to disable them, but normaly they should be detected and 
enabled by default (without any option) and this does not work with this 
patch, autogen.sh stop if you don't add any option. 

Danny


More information about the hal mailing list