[PATCH] fix sonypi/spicctrl set/get brightness support

David Zeuthen david at fubar.dk
Mon Feb 19 15:02:11 PST 2007


Hi,

Sorry for the lag! This looks good; it means things will work on Sony
laptops without having to rely on on the spicctrl tool yes?

Some comments:

 - it would probably be good with a --with-sonypi build configuration
   parameter and only build this for Linux for now. Would also remove
   all the #ifdef __FreeBSD__ and #ifdef sun conditionals

 - should probably use gtk-doc rather that Doxygen annotation if
   at all. Presently we only build docs for libraries.

 - Please avoid using C++ style comments

 - Do we need to open the device file all the time? I suppose so, as
   the driver probably is single opener?

 - Perhaps we need range checking for setting the brightness?

 - Perhaps improve on language in "Sets/Gets the bluetooth power" to be
   more along the lines of "Turn internal bluetooth adapter on/off". 
   I suspect that what it means?

 - I suspect the Bluetooth power control interface will follow and
   will be just an .fdi file?

Sorry again for the lag. 100 things going on here :-)

     David




More information about the hal mailing list