[PATCH] add support for copy_property for strlist properties

Danny Kukawka danny.kukawka at web.de
Wed Feb 28 10:36:00 PST 2007


On Mittwoch, 28. Februar 2007, David Zeuthen wrote:
> On Sat, 2007-02-24 at 17:35 +0100, Danny Kukawka wrote:
> > this patch adds support of the copy_property FDI directive for stringlist
> > properties. This would allow to copy/overwrite a stringlist with values
> > from e.g. an other device.
>
> Looks good; one thing however
>
> > +               /* don't bother setting the same value TODO: CHECK IF
> > THIS WORK */ +               if (hal_property_get_strlist (prop) ==
> > value)
> > +                       return TRUE;
>
> This is not going to work; you have to check all elements with strcmp().
>
> With such a change this is good to commit. Thanks.

I know that this would not work, I forgot to remove/remove this. IMO this is 
one thing I hate on GLib: the thing you really need are not there and 
everyone have to implement them again and again ... maybe I should patch 
glib ;-)

Danny


More information about the hal mailing list