[PATCH] fix hald crash after attempt to unmount ignored volume.

Danny Kukawka danny.kukawka at web.de
Thu Jan 4 11:32:48 PST 2007


On Thursday 04 January 2007 13:21, Andrey Borzenkov wrote:
> See details in http://qa.mandriva.com/show_bug.cgi?id=27333; if someone
> tries to unmount ignored media, hald crashes. 

IMO this lines doesn't crash HAL. I can't see how this can crash the daemon 
atm.

Btw. I attached a more clean patch to differ between the case where the call 
of libhal_device_get_property_bool() return correct true and the case where 
the call really fail and the error is set (and freed then).

> Patch attached as kmail tends to mangle lines :(

Please send the patch via KMAil with option "Suggest automatic display". ;-)

Cheers,

Danny

 hal-storage-shared.c |    9 ++++++---
 1 file changed, 6 insertions(+), 3 deletions(-)
-------------- next part --------------
A non-text attachment was scrubbed...
Name: hal-fix-dbus_error_hal-storage-shared.diff
Type: text/x-diff
Size: 780 bytes
Desc: not available
Url : http://lists.freedesktop.org/archives/hal/attachments/20070104/a904d494/hal-fix-dbus_error_hal-storage-shared.bin


More information about the hal mailing list