[PATCH] Some volume.ignore additions

David Zeuthen david at fubar.dk
Wed Jan 10 13:06:21 PST 2007


On Tue, 2007-01-09 at 13:09 +0100, Martin Pitt wrote:
> Hi,
> 
> In Ubuntu we modified 20-storage-methods.fdi to:
> 
>   * Also ignore Apple Bootstrap partitions on removable devices.

It's probably the right thing to ignore all such firmware partitions
regardless whether the drive is hotpluggable or uses removable media.
I've made that change. This is what I committed

 http://gitweb.freedesktop.org/?p=hal.git;a=commitdiff;h=a785b60d84d1799aed04462e1d1517e4a4c8a446;hp=69353b9c50d4da892f5bdd1cd75aa587870baada

Actually, now that HAL exports information read from the partition table
(as of 0.5.8.1) things like this

> <!-- Should always ignore Apple Bootstrap partitions (it would be -->
> <!-- a security hole to mount it) - TODO: should use the bootable -->
> <!-- flag from the Mac partition table instead -->

should be feasible to implement (I don't have my Powerbook 12" handy
though) rather easily by simply matching on the property we store in
volume.partition.flags whilst also checking storage.partitioning_scheme
equals 'apm' on the drive object.

>   * Ignore file systems without an usable file system (fsusage='').
>     Apart from ignoring unformatted partitions, this particularly gets
>     rid of 'Mac patch' partitions and similar things. (See
>     https://launchpad.net/bugs/18901)

This is probably a bug in gnome-vfs hal code; it should simply ignore
volumes where fsuage!=filesystem. There's other bugs in the gnome-vfs
hal code; for example I have a HP desktop with a built-in 4-in-1 USB
card reader and it does nothing when another 4-in-1 card reader is
plugged in via USB. 

I _hope_ to have time to look at this (and other issues) for GNOME 2.18
but am leaving tomorrow for a 2.5 week trip to Australia. 

      David




More information about the hal mailing list