[PATCH] add support for ACPI IBM hotkey events

Danny Kukawka danny.kukawka at web.de
Sun Jan 14 10:10:08 PST 2007


On Saturday 13 January 2007 13:06, Richard Hughes wrote:
> On Sat, 2007-01-13 at 20:36 +0100, Danny Kukawka wrote:
> > this patch adds support for the ACPI IBM hotkey events. I added the
> > code to
> > filter the events and send them out via HAL to the acpi addon because
> > we
> > don't need an new addon which also look on acpid/proc.
>
> I thought the long term plan was just to rely on ACPI using the input
> layer and not to propagate keycodes through HAL at all?

That can maybe be, but I can't see this happen atm. I don't get these events 
via the input layer. Do you (did you get this running with IBM machines in 
g-p-m?)? At least for me the sleep/s2disk(hibernate) and e.g. display off 
buttons on IBM machines are important. 

Since we already propagate these events for normal ACPI events via HAL (as we 
report the related buttons as devices) and also provide such events for 
Toshiba machines, I would see them also for IBM until this _all_ will go in 
the future through the input layer.

Danny


More information about the hal mailing list