[patch] initial OLPC battery and ac_adapter device support

David Zeuthen david at fubar.dk
Mon Jul 2 15:17:14 PDT 2007


On Sat, 2007-06-23 at 23:57 +0100, Richard Hughes wrote:
> Attached patch adds the battery and ac_adapter objects into the HAL
> device tree, using the power-supply kernel class.
> 
> Long term, the file reading functions probably need to be split into
> util_file.{c|h} and really need unit test cases. This is on my todo.
> 
> The battery code looks like it needs modularization for apm, acpi and
> apm, although this is hopefully being converted to power_supply in the
> kernel, making any big refactoring of HAL battery code unnecessary.
> 
> Attached patch makes my OLPC B3 work with HAL.
> 
> Please review,

The addition of the refresh method should probably be in a separate
patch with separate explanation / justification. There's still a few
(trivial?) TODO's left so I assume you want to iterate further over it?

      David
	



More information about the hal mailing list