[PATCH] hal-info-keymap-msi-s270.patch

Richard Hughes hughsient at gmail.com
Wed Jul 11 13:21:22 PDT 2007


On Wed, 2007-07-11 at 22:00 +0200, Lennart Poettering wrote:
> Hi!
> 
> The attached patch contains the keymap data for MSI S270 laptops. 

Cool, cheers dude. Pushed.

> This laptop generates keyboard events when the power cable is plugged
> in/plugged out. These events are completely redundant, because ACPI
> events are sent anyway. Thus I'd like to map this key to some code
> where they are essentially eaten. KEY_RESERVED is not an option,
> because this still fills up dmesg with those well known warnings about
> setkeycode. I am now using KEY_UNKNOWN which fills up dmesg slightly
> less, but still generates a warning when X11 is listening for raw kbd
> events. Better then before but not much better. I guess it would make
> sense to have a proper KEY_NULL or similar in the kernel.

Sure. Daniel, Dmitry, what do you think?

> Richard, you might want to add a few lines about KEY_RESERVED
> vs. KEY_UNKNOWN to your quirks web site? might be useful in other
> cases as well.

Cool. I'll add something tmw.

> I think this fdi block could safely be merged with the other MSI block
> that is already included. Unfortunately I don't have the full DMI data of
> that laptop around, hence I cannot really build a rule that works
> cleanly for both my S270 and the model that is already in the .fdi
> file.

Thats okay. In a little while we'll start to get a better idea of what
stuff is common between models and ranges and then we can start to
factor out common values.

Thanks,

Richard.



More information about the hal mailing list