make check addition for keymaps

Richard Hughes hughsient at gmail.com
Tue Jul 17 09:47:52 PDT 2007


On Tue, 2007-07-17 at 11:57 -0400, David Zeuthen wrote:
> On Thu, 2007-07-12 at 12:52 +0100, Richard Hughes wrote:
>  1. test script should live in tools/ and use $(srcdir)

Agree.

>  2. cannot make assumptions that hal is installed side-by-side with
>     this - vendors may want to run 'make check' in a buildroot

Sure. I've changed to to use the HAL source if available, and falling
back locally if not found.

>  3. there's a harcoded path to your home directory somewhere;

Ooops.

>  maybe
>     quirk-keymap-list.txt should be tools/known-keymap-entries.txt

I would prefer to keep the name as it means it could be trivially cp'd
from the hal source every time more keys are added.

>  4. various other things others suggested

Done. New patch attached.

Richard.

-------------- next part --------------
A non-text attachment was scrubbed...
Name: hal-add-make-check-keymaps.patch
Type: text/x-patch
Size: 5649 bytes
Desc: not available
Url : http://lists.freedesktop.org/archives/hal/attachments/20070717/f1b98770/attachment.bin 


More information about the hal mailing list