[patch] add keymap data to make random laptop vendor keys work

Daniel Stone daniel.stone at nokia.com
Mon Jun 4 05:14:18 PDT 2007


On Mon, Jun 04, 2007 at 12:56:34PM +0100, ext Richard Hughes wrote:
> On Mon, 2007-06-04 at 13:20 +0300, Daniel Stone wrote:
> > On Mon, Jun 04, 2007 at 11:16:07AM +0100, ext Richard Hughes wrote:
> > > On Mon, 2007-06-04 at 13:11 +0300, Daniel Stone wrote:
> > > > Should these not be under input?
> > > 
> > > The key prefix or the capability? Thanks.
> 
> How about the following patches?

> --- a/hald/linux/addons/.gitignore
> +++ b/hald/linux/addons/.gitignore
> --- a/hald/linux/probing/.gitignore
> +++ b/hald/linux/probing/.gitignore
> --- a/hald/run-hald.sh
> +++ b/hald/run-hald.sh

Separate patches?


> +static char *
> +find_atkbd_sysfs (void)
> +{
> +}

Uhm, this is already in input.device.

> +			if (strcmp (line, "N: Name=\"AT Translated Set 2 keyboard\"\n") == 0)

This is only correct for atkbd.c.  A better way would be to call
EVIOCGBITS with 0 as the argument, and then see if EV_KEY is in the
returned bitset.

Other than that, looks good to me.

Cheers,
Daniel
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
Url : http://lists.freedesktop.org/archives/hal/attachments/20070604/552dd760/attachment-0001.pgp 


More information about the hal mailing list