[PATCH] add new fdi match attribute contains_not for strlist

Danny Kukawka danny.kukawka at web.de
Wed Mar 7 00:48:17 PST 2007


On Dienstag, 6. März 2007, David Zeuthen wrote:
> Nitpicking, but
> 
> > +  if (value != NULL && haystack != NULL && strstr (haystack, value))
> 
> Should be strstr != 0. Apart from that it looks good. Thanks.

To be correct it should be 'strstr() != NULL' since strstr() returns char*.

I fixed this in the already existing code and reduced the patch to reuse
the already existing from MATCH_CONTAINS.

Danny
-------------- next part --------------
A non-text attachment was scrubbed...
Name: hal-add-MATCH_CONTAINS_NOT_for_string(-list)_v2.diff
Type: text/x-diff
Size: 2955 bytes
Desc: not available
Url : http://lists.freedesktop.org/archives/hal/attachments/20070307/b34603ce/hal-add-MATCH_CONTAINS_NOT_for_string-list_v2.bin


More information about the hal mailing list