circular dependency

Stepan Kasal kasal at ucw.cz
Wed Mar 14 03:02:10 PDT 2007


Hello,
  while building hal, my version of make (GNU Make 3.81) reports
circular dependency because of the rule
	ChangeLog: $(srcdir)/ChangeLog

With builddir = srcdir, this is the same file.

I recognize that we need a rule for "ChangeLog" to silence Automake.

Would not the following simplification be sufficient?

Thanks,
	Stepan Kasal
-------------- next part --------------
2007-03-14  Stepan Kasal  <kasal at ucw.cz>

	* Makefile.am (ChangeLog): Simplify the rules.

diff --git Makefile.am Makefile.am
index 4af0d42..02efcea 100644
--- Makefile.am
+++ Makefile.am
@@ -13,9 +13,7 @@ MAINTAINERCLEANFILES = ChangeLog
 
 # Creating ChangeLog from git log (taken from cairo/Makefile.am):
 
-ChangeLog: $(srcdir)/ChangeLog
-
-$(srcdir)/ChangeLog:
+ChangeLog:
 	@if test -d "$(srcdir)/.git"; then \
 	  (cd "$(srcdir)" && \
 	  ./missing --run git-log --stat) | fmt --split-only > $@.tmp \
@@ -29,7 +27,7 @@ $(srcdir)/ChangeLog:
 	  echo A git checkout and git-log is required to generate this file >> $@); \
 	fi
 
-.PHONY: ChangeLog $(srcdir)/ChangeLog
+.PHONY: ChangeLog
 
 DISTCLEANFILES = hal.pc hal-storage.pc intltool-extract intltool-merge intltool-update
 


More information about the hal mailing list