[PATCH] add soundcard device and fix device_file handling

David Zeuthen david at fubar.dk
Mon Mar 19 17:25:08 PDT 2007


On Mon, 2007-03-19 at 15:41 +0100, Danny Kukawka wrote:
> Hi,
> 
> this patch fixes these issues:
> * change checks for empty device file path from 'device_file == NULL' 
>   to 'device_file[0] == '\0'' since the device_file path is currently
>   never NULL but '\0' if empty/unset.

Should probably stil check for device_file != NULL before looking at the
first character...

> * Add the sound card device to HAL (e.g. /sys/devices/pci*/*/card0) to
>   represent the correct sysfs structure. All alsa and oss devices are 
>   now childs of the releated sound card device.

Not on my box... does this require a new kernel / ALSA version or some
special configuration? What's the point here btw and what's with the new
sound.* properties? Perhaps explaining a bit more what you want to
change, how it's going to look (lshal snippts) and why would be a good
starting point... Thanks.

      David




More information about the hal mailing list