[PATCH] Increase polling delay in addon-storage.c

[Doug Klima]

Danny Kukawka wrote:
> On Mittwoch, 28. November 2007, Robby Workman wrote:
>   
>> Discussion on IRC about the polling delay centered around the idea
>> that optical devices generally take 5 seconds or usually longer to
>> be ready for use, and as such a longer wait than 2 seconds is most
>> likely desirable.  Two points:
>> 1) The choice of 10 seconds is at least partly arbitrary - the
>>    individual who brought this up has drives that take 12-13 seconds,
>>    while mine takes about 7 seconds.  If some other number is better,
>>    then so be it.
>>     
>
> Uh, IMO this is at least for linux no good idea.
> 1) Currently it doesn't matter (IIRC) if the device is ready, if the device 
> isn't it get polled again in 2 seconds.
> 2) this effect also other devices than only CD/DVD devices
> 3) ... and what's more important: With this change HAL need in the worst case 
> 10 seconds to detect that the eject button of the device was pressed. This 
> would make a big regression to the users. 
>
> I can't see why we should change it to 10 sec. atm.
>
> Danny
>
> _______________________________________________
> hal mailing list
> hal at lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/hal
>   
As I suggested on IRC, if people need something similar to this. I could
see providing this as a configurable property per device for when the
addon gets started. Perhaps storage.media_check_interval (int). We could
simply update the hal-disable-polling tool (poorly named IMHO as well)
to write out FDI files to tweak that as well.