patch to use g_timeout_add_seconds()

Bastien Nocera hadess at hadess.net
Thu Feb 7 12:59:28 PST 2008


On Thu, 2008-02-07 at 22:36 +0200, Guillem Jover wrote:
> Hi,
> 
> On Wed, 2008-02-06 at 21:07:32 +0100, ext Sven Neumann wrote:
> > Attached is a patch that adds a configure check for GLib 2.14 and
> > changes some code (notably in the Linux specific parts) to use the new
> > functions when possible.
> 
> > diff --git a/configure.in b/configure.in
> > index d9efb89..aa82dde 100644
> > --- a/configure.in
> > +++ b/configure.in
> > @@ -622,6 +622,15 @@ PKG_CHECK_MODULES(GLIB, [$glib_module])
> 
> > +AC_MSG_CHECKING([if GLib is version 2.14.0 or newer])
> > +if $PKG_CONFIG --atleast-version=2.14.0 glib-2.0; then
> > +  have_glib_2_14=yes
> > +  AC_DEFINE(HAVE_GLIB_2_14, 1, [Define to 1 if GLib is version 2.14 or newer])
> > +else
> > +  have_glib_2_14=no
> > +fi
> > +AC_MSG_RESULT($have_glib_2_14)
> 
> Please, check for functionality instead of specific versions.

The functionality is documented, and has appeared in that version. I
don't see anything wrong with doing that way. Or we could just use a
newer glib.



More information about the hal mailing list