Bug with di_cache_coherency_check in hald.c

Joe Marcus Clarke marcus at FreeBSD.org
Sat Jan 5 05:23:54 PST 2008

On Sat, 2008-01-05 at 02:37 -0500, Joe Marcus Clarke wrote:
> I'm looking at hald.c, and di_cache_coherency_check() is called with a
> TRUE setup_watches argument prior to osspec_init() being called.  In
> that case, the file monitor will be NULL, and the watches will not be
> setup.  Shouldn't the calling of these two functions be reversed in
> hald.c?

Nevermind.  This was only applicable to FreeBSD where I initialized
file_monitor in osspec_init() since kqueue does not require root
privileges.  I moved it to osspec_privileged_init() to be in line with
the Linux backend.  The fact that the file_monitor needs to be
initialized in osspec_privileged_init() should probably be documented.


Joe Marcus Clarke
FreeBSD GNOME Team      ::      gnome at FreeBSD.org
FreeNode / #freebsd-gnome
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 187 bytes
Desc: This is a digitally signed message part
Url : http://lists.freedesktop.org/archives/hal/attachments/20080105/8948af56/attachment.pgp 

More information about the hal mailing list