[PATCH] hal sees two batteries
danny.kukawka at web.de
Tue Jan 29 14:49:30 PST 2008
On Samstag, 19. Januar 2008, Danny Kukawka wrote:
> On Mittwoch, 16. Januar 2008, Kyle McMartin wrote:
> > From: Kyle McMartin <kmcmartin at redhat.com>
> > I've turned on both ACPI_PROCFS_POWER and ACPI_SYSFS_POWER in Fedora
> > rawhide. With both options set, hal sees two battery devices, when it
> > should really only check the second if the first doesn't exist.
> > Fix this up by only checking procfs if we don't find anything in
> > sysfs.
> > Patch is against git HEAD.
> Without testing: could work to prevent the second battery, but would IMO
> solve not all problems with the sysfs acpi battery objects. Unfortunately I
> can not take a look again at the remaining problems before next week.
JFYI: with the latest git master the ACPI batteries in sysfs (in the
power_supply subsystem) should basicly work again.
We have to see if we need to change also the other power_supply batteries to
get polled. The time will show if there are other bugs in the code, or if
there are uncovered cornercases as in the ACPI proc related code.
More information about the hal