[hal-info patch] Some ThinkPad suspend quirks -- ok to commit?

[Martin Pitt]

Martin Pitt [2008-06-18 15:57 +0200]:
> I collected some additional ThinkPad quirks from
> https://launchpad.net/bugs/199059. 
> 
> OK for me to commit those?

> Subject: [PATCH] Add suspend quirk for yet another ThinkPad X31 model (2885).
> Subject: [PATCH] Add suspend quirk for IBM A31 (product ID 2652).
> Subject: [PATCH] Add suspend quirk for ThinkPad X32.

Since these are quite straightforward, I pushed them to trunk now.
Please LART me if there's anything wrong with them.

> Comment 31 [1] is an interesting case:
> 
>   system.hardware.product = '2672CBU' (string)
>   system.hardware.vendor = 'IBM' (string)
>   system.hardware.version = 'Not Available' (string)
> 
> On this system, the version name (X31 here) cannot be detected, so the
> dpms_quirk is not applied. Applying it unbreaks suspend/resume on that
> model. What do we do in this case? Ideally we would add it to 
> 
>       <match key="system.hardware.product" prefix_outof="2672;2673;2884;2885">
>         <match key="system.hardware.version" contains="X31">
>           <merge key="power_management.quirk.dpms_suspend" type="bool">true</merge>
> 
> somehow. Thanks for suggestions!

I'd still like to get some advice here.

Thanks,

Martin

-- 
Martin Pitt                        | http://www.piware.de
Ubuntu Developer (www.ubuntu.com)  | Debian Developer  (www.debian.org)
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
Url : http://lists.freedesktop.org/archives/hal/attachments/20080708/65dd08df/attachment.pgp