[PATCH 1/6] use embedded input_local.h instead of system linux/input.h

Danny Kukawka danny.kukawka at web.de
Sat Nov 1 03:28:50 PDT 2008


On Samstag, 1. November 2008, Guillem Jover wrote:
> Add and use a local copy of input.h from latest Linux to guarantee
> that the definitions that we need are going to be always present,
> to detangle what the build system supports from what HAL could support
> on the running system, and to make the build consistent between the
> system where 'make dist' was done and where the build happened.
>
> The only issue is that the header will have to be updated from time to
> time so that hal-setup-keymap can get the new KEY definitions.

I don't think we should use a local copy of input.h. IMO HAL shouldn't deliver 
a own copy of a kernel header (yes, there is some inotify stuff, but there is 
a patch in bugzilla to remove it and we should do it).  

It would be better to add some ifdefs instead of copy always stuff from the 
latest kernel version (it also extend the package size and the maintenance 
effort). IMO the input.h should always be from the system HAL gets compiled 
on and not from a maybe several versions newer kernel, which isn't installed 
in the system.

Danny



More information about the hal mailing list