[hal patch] increase helper timeout

[Danny Kukawka]

On Montag, 10. November 2008, Martin Pitt wrote:
> Hi all,
>
> Martin Pitt [2008-05-05 11:36 +0200]:
> > in https://launchpad.net/bugs/218834 we got a report that some CD-ROMs
> > are too slow to properly detect everything within the standard 10
> > seconds hal helper timeout:
> >
> > [6188]: 22:22:56.009 [D] probe-volume.c:379: Doing probe-volume for
> > /dev/scd0 [...]
> > [6182]: 22:22:58.002 [I] addon-storage.c:363: ... device /dev/scd0 is not
> > locked on HAL [6188]: 22:23:05.558 [D] probe-volume.c:542:
> > volume.disc.capacity = 2384855040 [...]
> > [6188]: 22:23:06.406 [E] probe-volume.c:302: Timed out probing /dev/scd0
> > - broken device driver?
> >
> > (NB the timestamps). Since the default 10 seconds seems to be pretty
> > much arbitrary, I just raised it to 20 for now. You might prefer a
> > more fine-grained approach, of course (let me know if I should change
> > this differently).
>
> This didn't get any response. It's a trivial patch, also recorded in
> bugzilla (#13009), and helps to cure the problem.
>
> I went ahead and committed it:
>
>  
> http://gitweb.freedesktop.org/?p=hal.git;a=commit;h=15604d786c6f88f1b80632b
>885e1029b32b9176b
>
> Please bash me if there's anything wrong with it.

I'm not sure if it's the right way to simply double the timeout (why 20s and 
not e.g. 15 or another number?). Especially since it looks as if this happen 
only in rare cases. 

And it looks to me as if it could be also a kernel problem (since some ppl. 
report that it worked with older kernel versions, but not with newer). Did 
someone check why it don't work for some devices (I got never such a report 
with SUSE products) and where it hangs?

Btw. If it hangs on probing the filesystem on the volume you can revert the 
change since we can also do this:
http://gitweb.freedesktop.org/?p=users/dkukawka/hal.git;a=commitdiff;h=7aca1f3fefefd3c760636aabcff1e25946ab6391

Danny