[PATCH] hal: Remove newer macbooks from the macbookpro addon

Henrik Rydberg rydberg at euromail.se
Sat Oct 25 02:55:32 PDT 2008


Backlight keeps getting darker on MacBookPro

Bug description from kjano at ubuntuforums.org:

i am using a macbook pro 3.1 with intrepid beta and the nvidia driver.
i finally managed to have the backlight keys F1 and F2 working but now
i face another problem. when i change the backlight setting, it resets
itself after some minutes to an average light level. then i use f2 to
increase backlight again and some time later it goes down again. i have
deactivated the shade setting in the gnome power management. the light
is also turned down while moving the mouse or typing.

https://bugs.launchpad.net/ubuntu/+source/hal/+bug/285815

It is correct that MacBookPro3,1 and later are not listed to use the
macbookpro addon. However, the light_sensor and keyboard_backlight
devices are also driven by the same addon, and thus the newer macbooks
should not be listed there either. Assuming that the gnome-power-manager
still treats the listed but missing light sensor, the symptom described
in this bug makes sense.

Signed-off-by: Henrik Rydberg <rydberg at euromail.se>
---
 fdi/policy/10osvendor/10-macbookpro-utils.fdi |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/fdi/policy/10osvendor/10-macbookpro-utils.fdi b/fdi/policy/10osvendor/10-macbookpro-utils.fdi
index 60882a2..a3cf92e 100644
--- a/fdi/policy/10osvendor/10-macbookpro-utils.fdi
+++ b/fdi/policy/10osvendor/10-macbookpro-utils.fdi
@@ -6,7 +6,7 @@
   <device>
     <match key="system.kernel.name" string="Linux">
       <match key="system.hardware.vendor" contains="Apple">
-        <match key="system.hardware.product" string_outof="MacBookPro1,1;MacBookPro1,2;MacBookPro2,1;MacBookPro2,2;MacBookPro3,1;MacBookPro3,2;MacBookPro4,1">
+        <match key="system.hardware.product" string_outof="MacBookPro1,1;MacBookPro1,2;MacBookPro2,1;MacBookPro2,2">
           <spawn udi="/org/freedesktop/Hal/devices/macbook_pro_light_sensor"/>
           <spawn udi="/org/freedesktop/Hal/devices/macbook_pro_keyboard_backlight"/>
 	</match>
-- 
1.5.6.3



More information about the hal mailing list