[PATCH] Make joystick probing more robust

[Martin Pitt]

Martin Pitt [2008-10-28  9:12 +0100]:
> For the record, there is a Launchpad bug report [1] with another
> proposed patch [2]. TIMTOWTDI, I figure...

Ari writes:

 "The patch proposed on the mailing list works for joysticks, but
 still incorrectly detects tablets as touchpads since the check for
 touchpads just tests for pressure, which is common to both tablets
 and touchpads.  The actual check for tablets is inside a block whose
 condition is never true, and even if the execution ever got there,
 the tablet would be marked as a joystick as well... So my patch isn't
 so simple because the situation isn't so simple for all the device
 types involved and because some parts of the original code were
 incorrect."

So this seems to be more comprehensive. Matthew, would you mind having
a quick look over this patch?

I tested it with my Logitech Thrustmaster, the internal laptop
touchpad, and an external USB mouse, and input.{mouse,joystick}
properties work as expected now. I don't have a touchpad or tablet to
test, though.

Martin
-- 
Martin Pitt                        | http://www.piware.de
Ubuntu Developer (www.ubuntu.com)  | Debian Developer  (www.debian.org)
-------------- next part --------------
A non-text attachment was scrubbed...
Name: hal-input-test-abs.patch
Type: text/x-diff
Size: 2726 bytes
Desc: not available
Url : http://lists.freedesktop.org/archives/hal/attachments/20081029/ac078456/attachment.patch