patch for pm-utils quirks for Asus P4B266

Martin Pitt martin.pitt at ubuntu.com
Thu Jul 16 01:49:44 PDT 2009


Hello Olivier,

sorry for the late answer, I'm collecting lost threads/patches on this
ML.

Olivier Berger [2009-03-28 19:38 +0100]:
> Please receive this patch which adds proper suspend quirks for P4B266
> mainboards.
>
> +    <match key="system.firmware.version" prefix="ASUS P4B266 ACPI BIOS Revision">
> +      <match key="system.firmware.version" contains=" 1010">
> +	<merge key="power_management.quirk.s3_bios" type="bool">true</merge>
> +	<merge key="power_management.quirk.s3_mode" type="bool">true</merge>
> +      </match>
> +    </match>
> +

This doesn't look appropriate to me. Suspend quirks are highly
dependent on the video card/driver, I don't think that the motherboard
alone suffices to determine the right set. I'm afraid that systems
without proper DMI data (i. e. particular laptop models which come
with a fixed graphics card type) cannot be adequately represented in
hal-info. Also, with the new generation video drivers (KMS) this is
all obsolete anyway.

Thanks,

Martin

-- 
Martin Pitt                        | http://www.piware.de
Ubuntu Developer (www.ubuntu.com)  | Debian Developer  (www.debian.org)
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 197 bytes
Desc: Digital signature
Url : http://lists.freedesktop.org/archives/hal/attachments/20090716/0dc8fff0/attachment.pgp 


More information about the hal mailing list