Dear Sir, The code does same thing as existing code and why this is a layer violation and existing one is not ? It just get LED status change instead of setting it and this make OSD design clean and clear without polling LED status and make unnecessary Xlib dependency .   BR, Sam <div>2007/11/28, Daniel Stone <<a href="mailto:daniel.stone@nokia.com" target="_blank" onclick="return top.js.OpenExtLink(window,event,this)">daniel.stone@nokia.com</a> >:<blockquote class="gmail_quote" style="border-left: 1px solid rgb(204, 204, 204); margin: 0pt 0pt 0pt 0.8ex; padding-left: 1ex;"><div> On Wed, Nov 28, 2007 at 03:47:46AM +0800, ext Sam Lin wrote: > For tablet/UMPC there is a requirement to make NumLock/CapsLock status > visible on systray or on OSD and > that make condition signal of such status change from addon-input.c helpful. Please don't do this.  All your interaction with keyboards is through X, so why cause a layering violation? Just ask X for the LED status. Cheers, Daniel </div> -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.6 (GNU/Linux) iD8DBQFHTKMk68xJuWtYYdURAsuoAJ9rnRId7RaHFJ8Z+zZMSdB1fLUjwgCfaZVF iZKisTX86aHBzQCqUcnv8hc= =U/Oi -----END PGP SIGNATURE----- </blockquote></div>