Hi Behdad,<div><br></div><div>Thank you for the change, but it seems that we need to do it for hb_apply_context_t(), not hb_would_apply_context_t() to fix the crash :)</div><div><br></div><div class="gmail_extra"><br><br><div class="gmail_quote">

On Tue, Sep 4, 2012 at 9:19 AM, Behdad Esfahbod <span dir="ltr"><<a href="mailto:behdad@kemper.freedesktop.org" target="_blank">behdad@kemper.freedesktop.org</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">

 src/hb-ot-layout-gsubgpos-private.hh |    2 +-<br>
 1 file changed, 1 insertion(+), 1 deletion(-)<br>
<br>
New commits:<br>
commit f8fa2b5cf67b02d74514dec7885d03de73ec7349<br>
Author: Behdad Esfahbod <<a href="mailto:behdad@behdad.org">behdad@behdad.org</a>><br>
Date:   Mon Sep 3 20:19:46 2012 -0400<br>
<br>
    Fix possible NULL dereference<br>
<br>
    As reported by Kenichi Ishibashi.<br>
<br>
diff --git a/src/hb-ot-layout-gsubgpos-private.hh b/src/hb-ot-layout-gsubgpos-private.hh<br>
index 00bc563..40d5c57 100644<br>
--- a/src/hb-ot-layout-gsubgpos-private.hh<br>
+++ b/src/hb-ot-layout-gsubgpos-private.hh<br>
@@ -92,7 +92,7 @@ struct hb_would_apply_context_t<br>
                              glyphs (glyphs_),<br>
                              len (len_),<br>
                              zero_context (zero_context_),<br>
-                             digest (*digest_),<br>
+                             digest (digest_ ? *digest_ : hb_set_digest_t()),<br>
                              debug_depth (0) {};<br>
 };<br>
<br>
_______________________________________________<br>
HarfBuzz mailing list<br>
<a href="mailto:HarfBuzz@lists.freedesktop.org">HarfBuzz@lists.freedesktop.org</a><br>
<a href="http://lists.freedesktop.org/mailman/listinfo/harfbuzz" target="_blank">http://lists.freedesktop.org/mailman/listinfo/harfbuzz</a><br>
</blockquote></div><br></div>