[PATCH libevdev 08/10] doxygen: fix 'distcheck' for tarballs srcdir!=builddir without doxygen

Gaetan Nadon memsize at videotron.ca
Mon Nov 25 08:07:31 PST 2013


On 13-11-24 07:41 PM, Peter Hutterer wrote:
> (follow-up to that now that I synced the whole thread. for some reason this
> email came in first and I didn't see the follow-ups until much later)
>
> the above still stands, I don't think we need to succeed make dist or make
> distcheck if doxygen is missing. Both are imo a maintainer operation and
> should thus require the full set of dependencies.
Totally agree. Lost track of this perspective.
>
> patches 01-06 are merged. 07 and 08 I think shouldn't be merged for the
> above reasons, and that would drop the need for 10 as well since dist
> requires doxygen. that leaves 09 which I think is useful.
>
> Now the question is for whether to add $(builddir) to the doc_src find
> command as a separate patch?
Should be consistent, I ran the tests again without any $(builddir) and
it's ok.
I submitted a patch.
>
> also, thanks for those patches. that "find: no such file or directory" has
> been going on my nerves for a while now :)
Call it a nicotine patch :-)

Updated test matrix. One cannot patch a tarball and re-distribute with
out-dated docs.

    Doxy:        doxygen tool is installed to generate html from header
    files
    srcdir:      the html docs are generated in the same directory as
    the source
    builldir:    the html docs are generated in a deparate build directory
    git vs tar:  build is done from git cloned module or from a tarball
    (with html)
    no-html:     the html files in the tarball have been deleted (make
    clean)

    Doxy;        srcdir;        git;        no-html:    tarball created
    Doxy;        srcdir;        tar;        html:       tarball created
    Doxy;        srcdir;        tar;        no-html:    tarball created
    Doxy;        builddir;      git;        no-html:    tarball created
    Doxy;        builddir;      tar;        html:       tarball created
    Doxy;        builddir;      tar;        no-html:    tarball created

    No-doxy;     srcdir;        git;        no-html:    Refusing dist Msg
    No-doxy;     srcdir;        tar;        html:       Refusing dist Msg
    No-doxy;     builddir;      git;        no-html:    Refusing dist Msg
    No-doxy;     builddir;      tar;        html:       Refusing dist Msg




More information about the Input-tools mailing list