[PATCH libevdev 4/5] Add name-resolver unit tests

David Herrmann dh.herrmann at gmail.com
Mon Oct 7 04:07:10 PDT 2013


Hi Peter

On Mon, Oct 7, 2013 at 3:17 AM, Peter Hutterer <peter.hutterer at who-t.net> wrote:
> On Fri, Oct 04, 2013 at 08:39:26PM +0200, David Herrmann wrote:
>> I forgot to mention that I didn't add proper tests for the
>> libevdev_event_code_from_name() function. I want to get an ACK for the
>> API first before I add tests that I have to rewrite later, anyway.
>
> tbh, you should write tests anyway, especially if you think the API may
> change.  writing tests (especially if you do it a day or two after writing
> the API) often shows up inconsistencies with the API, room for improvements,
> etc.
>
> yes, it's annoying to rewrite tests. but still worth the time. consider them
> as the first user of your new API.

Meeeh, but.. ok.

Cheers
Conscience-stricken David


More information about the Input-tools mailing list