[PATCH v2 libevdev] Drain all events before synchronizing after SYN_DROPPED

David Herrmann dh.herrmann at gmail.com
Thu Apr 10 10:35:46 PDT 2014


Hi

On Thu, Apr 10, 2014 at 3:23 AM, Peter Hutterer
<peter.hutterer at who-t.net> wrote:
> You missed the last paragraph of that commit message:
> "Note that the above is true for EV_ABS events, for EV_KEY, EV_SND, EV_LED
> and EV_SW the kernel removes potential duplicates from the client buffer
> anyway.  Really, this should be fixed in the kernel for EV_ABS, but until
> then we need this solution."

Hah! I only read the first patch, but commented on the second. My bad.
I will send a patch to Dmitry to fix it upstream. Should be fairly
easy. I didn't do it in the first place as I thought ABS/REL values
are refreshed so fast that we don't need any flushing. However, I
obviously missed the slot reports.

Thanks
David


More information about the Input-tools mailing list