<html>
<head>
<base href="https://bugs.freedesktop.org/" />
</head>
<body><span class="vcard"><a class="email" href="mailto:stereotype441@gmail.com" title="Paul Berry <stereotype441@gmail.com>"> <span class="fn">Paul Berry</span></a>
</span> changed
<a class="bz_bug_link
bz_status_RESOLVED bz_closed"
title="RESOLVED FIXED - [IVB/HSW Bisected]Piglit spec/glsl-1.50/execution/geometry/core-inputs fails"
href="https://bugs.freedesktop.org/show_bug.cgi?id=70820">bug 70820</a>
<br>
<table border="1" cellspacing="0" cellpadding="8">
<tr>
<th>What</th>
<th>Removed</th>
<th>Added</th>
</tr>
<tr>
<td style="text-align:right;">Status</td>
<td>NEW
</td>
<td>RESOLVED
</td>
</tr>
<tr>
<td style="text-align:right;">Resolution</td>
<td>---
</td>
<td>FIXED
</td>
</tr>
<tr>
<td style="text-align:right;">Assignee</td>
<td>idr@freedesktop.org
</td>
<td>stereotype441@gmail.com
</td>
</tr></table>
<p>
<div>
<b><a class="bz_bug_link
bz_status_RESOLVED bz_closed"
title="RESOLVED FIXED - [IVB/HSW Bisected]Piglit spec/glsl-1.50/execution/geometry/core-inputs fails"
href="https://bugs.freedesktop.org/show_bug.cgi?id=70820#c1">Comment # 1</a>
on <a class="bz_bug_link
bz_status_RESOLVED bz_closed"
title="RESOLVED FIXED - [IVB/HSW Bisected]Piglit spec/glsl-1.50/execution/geometry/core-inputs fails"
href="https://bugs.freedesktop.org/show_bug.cgi?id=70820">bug 70820</a>
from <span class="vcard"><a class="email" href="mailto:stereotype441@gmail.com" title="Paul Berry <stereotype441@gmail.com>"> <span class="fn">Paul Berry</span></a>
</span></b>
<pre>Fixed by commit 172aec281d3d4eb0709977e0748d137e56aacd90
Author: Paul Berry <<a href="mailto:stereotype441@gmail.com">stereotype441@gmail.com</a>>
Date: Wed Oct 23 07:55:09 2013 -0700
glsl: set explicit_location correctly in lower_named_interface_blocks.
When lower_named_interface_blocks lowers a built-in interface block
member to an ir_variable, it needs to set explicit_location in the
ir_variable. Otherwise the linker gets confused and treats the
variable as a generic varying.
Fixes the following piglit tests, which were regressed by commit
63974c0 (glsl: Simplify the interface to
link_invalidate_variable_locations):
- clip-distance-bulk-copy
- clip-distance-in-bulk-read
- clip-distance-in-explicitly-sized
- clip-distance-in-param
- clip-distance-in-values
- core-inputs
- gs-redeclares-both-pervertex-blocks
- gs-redeclares-pervertex-in-only
- redeclare-pervertex-subset-vs-to-gs
- unsized-in-named-interface-block-gs
- unsized-in-named-interface-block-multiple
- unsized-in-unnamed-interface-block-gs
- unsized-in-unnamed-interface-block-multiple
Bugzilla: <a class="bz_bug_link
bz_status_RESOLVED bz_closed"
title="RESOLVED FIXED - [IVB/HSW Bisected]Piglit spec/glsl-1.50/execution/geometry/core-inputs fails"
href="show_bug.cgi?id=70820">https://bugs.freedesktop.org/show_bug.cgi?id=70820</a>
Reviewed-by: Ian Romanick <<a href="mailto:ian.d.romanick@intel.com">ian.d.romanick@intel.com</a>>
Reviewed-by: Matt Turner <<a href="mailto:mattst88@gmail.com">mattst88@gmail.com</a>></pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the QA Contact for the bug.</li>
</ul>
</body>
</html>