<html> <head> <base href="https://bugs.freedesktop.org/" /> </head> <body> <div> <a class="bz_bug_link bz_status_NEW " title="NEW --- - Metro: Last Light rendering issues" href="https://bugs.freedesktop.org/show_bug.cgi?id=71870#c10">Comment # 10</a> on <a class="bz_bug_link bz_status_NEW " title="NEW --- - Metro: Last Light rendering issues" href="https://bugs.freedesktop.org/show_bug.cgi?id=71870">bug 71870</a> from <a class="email" href="mailto:stereotype441@gmail.com" title="Paul Berry <stereotype441@gmail.com>"> Paul Berry</a> <pre>(In reply to <a href="show_bug.cgi?id=71870#c9">comment #9</a>) > (In reply to <a href="show_bug.cgi?id=71870#c8">comment #8</a>) > > (In reply to <a href="show_bug.cgi?id=71870#c7">comment #7</a>) > > > Tapani, can you please try running Metro again with > > <a href="http://lists.freedesktop.org/archives/mesa-dev/2013-November/049081.html">http://lists.freedesktop.org/archives/mesa-dev/2013-November/049081.html</a> > > applied? I'm hoping that this will fix the crash issue and take you back to > > the state where there are just rendering issues. > > Yes, just confirmed that this patch fixes the crash Ok, the crash is fixed by commit 2714ca81b9bad3dec3894fac97f34502c80b1697 Author: Paul Berry <<a href="mailto:stereotype441@gmail.com">stereotype441@gmail.com</a>> Date: Mon Nov 25 08:03:24 2013 -0800 i965/gs: Properly skip GS binding table upload when no GS active. Previously, in brw_gs_upload_binding_table(), we checked whether brw->gs.prog_data was NULL in order to determine whether a geometry shader was active. This didn't work: brw->gs.prog_data starts off as NULL, but it is set to non-NULL when a geometry shader program is built, and then never set to NULL again. As a result, if we called brw_gs_upload_binding_table() while there was no geometry shader active, but a geometry shader had previously been active, it would refer to a stale (and possibly freed) prog_data structure. This patch fixes the problem by modifying brw_gs_upload_binding_table() to use the proper technique to determine whether a geometry shader is active: by checking whether brw->geometry_program is NULL. This fixes the crash reported in <a href="show_bug.cgi?id=71870#c2">comment 2</a> of <a class="bz_bug_link bz_status_NEW " title="NEW --- - Metro: Last Light rendering issues" href="show_bug.cgi?id=71870">bug 71870</a> (the incorrect rendering remains, however). Bugzilla: <a class="bz_bug_link bz_status_NEW " title="NEW --- - Metro: Last Light rendering issues" href="show_bug.cgi?id=71870">https://bugs.freedesktop.org/show_bug.cgi?id=71870</a> Cc: <a href="mailto:mesa-stable@lists.freedesktop.org">mesa-stable@lists.freedesktop.org</a> Reviewed-by: Chris Forbes <<a href="mailto:chrisf@ijw.co.nz">chrisf@ijw.co.nz</a>> Reviewed-by: Eric Anholt <<a href="mailto:eric@anholt.net">eric@anholt.net</a>> Reviewed-by: Kenneth Graunke <<a href="mailto:kenneth@whitecape.org">kenneth@whitecape.org</a>></pre> </div> <hr> You are receiving this mail because: <ul> <li>You are the QA Contact for the bug.</li> </ul> </body> </html>