<html>
<head>
<base href="https://bugs.freedesktop.org/" />
</head>
<body><span class="vcard"><a class="email" href="mailto:krh@bitplanet.net" title="Kristian Høgsberg <krh@bitplanet.net>"> <span class="fn">Kristian Høgsberg</span></a>
</span> changed
<a class="bz_bug_link
bz_status_NEW "
title="NEW --- - [SNB Regression]Piglit/glx_GLX_ARB_create_context_current_with_no_framebuffer segfault"
href="https://bugs.freedesktop.org/show_bug.cgi?id=74143">bug 74143</a>
<br>
<table border="1" cellspacing="0" cellpadding="8">
<tr>
<th>What</th>
<th>Removed</th>
<th>Added</th>
</tr>
<tr>
<td style="text-align:right;">CC</td>
<td>
</td>
<td>idr@freedesktop.org
</td>
</tr></table>
<p>
<div>
<b><a class="bz_bug_link
bz_status_NEW "
title="NEW --- - [SNB Regression]Piglit/glx_GLX_ARB_create_context_current_with_no_framebuffer segfault"
href="https://bugs.freedesktop.org/show_bug.cgi?id=74143#c5">Comment # 5</a>
on <a class="bz_bug_link
bz_status_NEW "
title="NEW --- - [SNB Regression]Piglit/glx_GLX_ARB_create_context_current_with_no_framebuffer segfault"
href="https://bugs.freedesktop.org/show_bug.cgi?id=74143">bug 74143</a>
from <span class="vcard"><a class="email" href="mailto:krh@bitplanet.net" title="Kristian Høgsberg <krh@bitplanet.net>"> <span class="fn">Kristian Høgsberg</span></a>
</span></b>
<pre>Adding irc discussion with Ian here:
12:15 < idr> krh: In the None drawable case, both read and draw must be None.
Is that checked somewhere?
...
12:29 < krh> idr: seems like something we should do in MakeContextCurrent, but
I don't see it there
12:30 < krh> idr: if only one of them is NULL, the dri driver will crash
12:30 < idr> I'm also not sure how we'll enforce the "...and the OpenGL version
supported by <ctx> is 3.0 or greater." requirement. :(
12:30 < idr> Now or with your patch?
12:31 < krh> without my patch, the driver would never see a NULL draw/readable
12:32 < krh> so it wouldn't hit that case
I think further checking and validation of the extension makes sense, but it's
orthogonal to fixing this regression. Once change in behavior is that without
the patch in <a href="show_bug.cgi?id=74143#c4">comment 4</a>, passing a None and a non-None drawable to
glxMakeContext Current I get
X Error of failed request: BadDrawable (invalid Pixmap or Window parameter)
Major opcode of failed request: 152 (DRI2)
Minor opcode of failed request: 3 (DRI2CreateDrawable)
Resource id in failed request: 0x0
Serial number of failed request: 35
Current serial number in output stream: 37
with the patch we segfault instead.
So more work is needed to better check input, but that's not a new problem.
Unless Ian objects, I'll commit this tomorrow.</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the QA Contact for the bug.</li>
</ul>
</body>
</html>