<html>
<head>
<base href="https://bugs.freedesktop.org/" />
</head>
<body><span class="vcard"><a class="email" href="mailto:idr@freedesktop.org" title="Ian Romanick <idr@freedesktop.org>"> <span class="fn">Ian Romanick</span></a>
</span> changed
<a class="bz_bug_link
bz_status_NEW "
title="NEW --- - intel_mipmap_tree.c:728:7: error: void function 'intel_update_winsys_renderbuffer_miptree' should not return a value [-Wreturn-type]"
href="https://bugs.freedesktop.org/show_bug.cgi?id=75172">bug 75172</a>
<br>
<table border="1" cellspacing="0" cellpadding="8">
<tr>
<th>What</th>
<th>Removed</th>
<th>Added</th>
</tr>
<tr>
<td style="text-align:right;">Assignee</td>
<td>idr@freedesktop.org
</td>
<td>eric@anholt.net
</td>
</tr>
<tr>
<td style="text-align:right;">CC</td>
<td>
</td>
<td>idr@freedesktop.org
</td>
</tr></table>
<p>
<div>
<b><a class="bz_bug_link
bz_status_NEW "
title="NEW --- - intel_mipmap_tree.c:728:7: error: void function 'intel_update_winsys_renderbuffer_miptree' should not return a value [-Wreturn-type]"
href="https://bugs.freedesktop.org/show_bug.cgi?id=75172#c1">Comment # 1</a>
on <a class="bz_bug_link
bz_status_NEW "
title="NEW --- - intel_mipmap_tree.c:728:7: error: void function 'intel_update_winsys_renderbuffer_miptree' should not return a value [-Wreturn-type]"
href="https://bugs.freedesktop.org/show_bug.cgi?id=75172">bug 75172</a>
from <span class="vcard"><a class="email" href="mailto:idr@freedesktop.org" title="Ian Romanick <idr@freedesktop.org>"> <span class="fn">Ian Romanick</span></a>
</span></b>
<pre>I see two problems in the function that prevent me from proposing the obvious,
trivial fix.
1. This looks like an error case, and the caller should be signaled. It looks
like previous to 019560c1 the caller was signaled, but ignored it.
2. It looks like there's a potential leak of irb->singlesample_mt, but I don't
know the surrounding code well enough to be sure.</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the QA Contact for the bug.</li>
</ul>
</body>
</html>