<html> <head> <base href="https://bugs.freedesktop.org/" /> </head> <body> <div> <a class="bz_bug_link bz_status_NEW " title="NEW --- - [i965 Bisected]Piglit/glx_glx-make-glxdrawable-current fails" href="https://bugs.freedesktop.org/show_bug.cgi?id=74005#c6">Comment # 6</a> on <a class="bz_bug_link bz_status_NEW " title="NEW --- - [i965 Bisected]Piglit/glx_glx-make-glxdrawable-current fails" href="https://bugs.freedesktop.org/show_bug.cgi?id=74005">bug 74005</a> from <a class="email" href="mailto:itoral@igalia.com" title="Iago Toral <itoral@igalia.com>"> Iago Toral</a> <pre>Created <a href="attachment.cgi?id=95650" name="attach_95650" title="Patch">attachment 95650</a> <a href="attachment.cgi?id=95650&action=edit" title="Patch">[details]</a> <a href='page.cgi?id=splinter.html&bug=74005&attachment=95650'>[review]</a> Patch The problem seems to live in the fact that we check whether we have a viewport set to decide if we need to generate buffers for the drawable. This is not a valid solution for the scenario in which we switch drawables for the same context, since the viewport will be initialized the first time that we call MakeCurrent with one of the drawables. Thus, switching to a different drawable after the first MakeCurrent will not produce buffers for the new drawable, leading to the problem. The patch reverts the behavior to the original solution with a small change to support single buffer drawables (which was the reason the bad commit was introduced). Basically, it checks if we have a render buffer for the drawable, but instead of checking the BACK_LEFT buffer which only works for double buffer drawables we check the FRONT_LEFT buffer, which should work for both single buffer and double buffer drawables.</pre> </div> <hr> You are receiving this mail because: <ul> <li>You are the QA Contact for the bug.</li> </ul> </body> </html>