<html> <head> <base href="https://bugs.freedesktop.org/" /> </head> <body> <div> <a class="bz_bug_link bz_status_ASSIGNED " title="ASSIGNED --- - [HSW] DOTA world lighting has no effect" href="https://bugs.freedesktop.org/show_bug.cgi?id=76749#c14">Comment # 14</a> on <a class="bz_bug_link bz_status_ASSIGNED " title="ASSIGNED --- - [HSW] DOTA world lighting has no effect" href="https://bugs.freedesktop.org/show_bug.cgi?id=76749">bug 76749</a> from <a class="email" href="mailto:olvaffe@gmail.com" title="Chia-I Wu <olvaffe@gmail.com>"> Chia-I Wu</a> <pre>(In reply to <a href="show_bug.cgi?id=76749#c13">comment #13</a>) > (In reply to <a href="show_bug.cgi?id=76749#c12">comment #12</a>) > > (In reply to <a href="show_bug.cgi?id=76749#c11">comment #11</a>) > > > I'll see if I can spot the problem with the saturation propagation pass. I > > > can reproduce the issue with Jordan's trace. > > > > I think I've found the shader that it's incorrectly optimizing. > > I've sent a three patch series to fix some bugs in the saturate propagation > pass. It fixes some lighting issues (the whole scene looked too dark > before), but doesn't affect the issue Jordan's pngs show. The patch in the attachments should fix this bug. I am on holidays, and haven't had a chance to look at the patches for VS DCE and saturation propagation. I will take a look once I get back, of course unless they have been committed by then.</pre> </div> <hr> You are receiving this mail because: <ul> <li>You are the QA Contact for the bug.</li> </ul> </body> </html>