<html>
<head>
<base href="https://bugs.freedesktop.org/" />
</head>
<body>
<p>
<div>
<b><a class="bz_bug_link
bz_status_REOPENED "
title="REOPENED --- - [IVB/HSW] ogl-samples: gl-320-primitive-shading output errors"
href="https://bugs.freedesktop.org/show_bug.cgi?id=76394#c7">Comment # 7</a>
on <a class="bz_bug_link
bz_status_REOPENED "
title="REOPENED --- - [IVB/HSW] ogl-samples: gl-320-primitive-shading output errors"
href="https://bugs.freedesktop.org/show_bug.cgi?id=76394">bug 76394</a>
from <span class="vcard"><a class="email" href="mailto:Dieter@nuetzel-hh.de" title="Dieter Nützel <Dieter@nuetzel-hh.de>"> <span class="fn">Dieter Nützel</span></a>
</span></b>
<pre>(In reply to <a href="show_bug.cgi?id=76394#c5">comment #5</a>)
<span class="quote">> Committed as:
>
> commit 6d0e30c6a332de9ea7ab00e1fd303df2fb337c64
> Author: Iago Toral Quiroga <<a href="mailto:itoral@igalia.com">itoral@igalia.com</a>>
> Date: Fri Apr 4 15:11:15 2014 +0200
>
> glsl: Properly handle blocks that define the same field name.
>
> Currently we can have name space collisions between blocks that define
> the same
> fields. For example:
>
> in block
> {
> vec4 Color;
> } In[];
>
> out block
> {
> vec4 Color;
> } Out;
>
> These two blocks will assign the same interface name (block.Color) to
> the Color
> field in flatten_named_interface_blocks_declarations.cpp, leading to
> havoc.
> This was breaking badly the gl-320-primitive-shading test from
> ogl-samples.
>
> The patch uses the block instance name to avoid collisions, producing
> names
> like block.In.Color and block.Out.Color to avoid the name clash.
>
> Bugzilla: <a class="bz_bug_link
bz_status_REOPENED "
title="REOPENED --- - [IVB/HSW] ogl-samples: gl-320-primitive-shading output errors"
href="show_bug.cgi?id=76394">https://bugs.freedesktop.org/show_bug.cgi?id=76394</a>
> Reviewed-by: Kenneth Graunke <<a href="mailto:kenneth@whitecape.org">kenneth@whitecape.org</a>></span >
Your nice patch fixed gl-320-primitive-shading test mostly, here.
Before, I only got an empty black window.
Now, it shows only little partial damage which changes during mouse rotation
(right button). See attchment:
gl-320-primitive-shading-brocken.png
Related bug was:
<a class="bz_bug_link
bz_status_NEW "
title="NEW --- - r600g: 'invalid read' linking geometry shader"
href="show_bug.cgi?id=74717">https://bugs.freedesktop.org/show_bug.cgi?id=74717</a>
<span class="quote">> Marking fixed. But...I'm not sure if those errors are expected. If not, we
> should probably reopen this (and change the title)...</span >
Oh,...
But I'm on r600g (RV730 AGP), so...</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the QA Contact for the bug.</li>
</ul>
</body>
</html>