<html>
<head>
<base href="https://bugs.freedesktop.org/" />
</head>
<body>
<p>
<div>
<b><a class="bz_bug_link
bz_status_NEW "
title="NEW --- - [bisected regression] piglit spec/glsl-1.50/compiler/incorrect-in-layout-qualifier-repeated-prim.geom"
href="https://bugs.freedesktop.org/show_bug.cgi?id=80778#c4">Comment # 4</a>
on <a class="bz_bug_link
bz_status_NEW "
title="NEW --- - [bisected regression] piglit spec/glsl-1.50/compiler/incorrect-in-layout-qualifier-repeated-prim.geom"
href="https://bugs.freedesktop.org/show_bug.cgi?id=80778">bug 80778</a>
from <span class="vcard"><a class="email" href="mailto:siglesias@igalia.com" title="Samuel Iglesias <siglesias@igalia.com>"> <span class="fn">Samuel Iglesias</span></a>
</span></b>
<pre>(In reply to <a href="show_bug.cgi?id=80778#c3">comment #3</a>)
<span class="quote">> (In reply to <a href="show_bug.cgi?id=80778#c2">comment #2</a>)
> > Created <span class=""><a href="attachment.cgi?id=102112" name="attach_102112" title="Patch to fix the issue">attachment 102112</a> <a href="attachment.cgi?id=102112&action=edit" title="Patch to fix the issue">[details]</a></span> <a href='page.cgi?id=splinter.html&bug=80778&attachment=102112'>[review]</a> [review] [review]
> > Patch to fix the issue
> >
> > I have reproduced the error. Attached is the patch to fix it.
> >
> > Please test it. If it is OK I will send it to the mailing list.
>
> Were you able to verify the patch?
> </span >
Yes, I verified it.
<span class="quote">> It is usually easier to reply to email with comments.
> So, I would suggest just sending it to the list after
> you have tested it and feel fairly confident in the
> patch.
> </span >
OK, I will do that as of now. Thanks for the tip!
<span class="quote">> Nevertheless, my comments on the patch are,
> how about creating a new local variable?
>
> ast_type_qualifier allowed_duplicates_mask;
> allowed_duplicates_mask.flags.i =
> ubo_mat_mask.flags.i |
> ubo_layout_mask.flags.i |
> ubo_binding_mask.flags.i;
> if (state->stage == MESA_SHADER_GEOMETRY)
> allowed_duplicates_mask.flags.i |=
> stream_layout_mask.flags.i;</span >
Good idea. I'm going to create that variable to simplify the code and submit it
to the mailing list.
Thanks,
Sam</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the QA Contact for the bug.</li>
</ul>
</body>
</html>