<html> <head> <base href="https://bugs.freedesktop.org/" /> </head> <body> <div> <a class="bz_bug_link bz_status_NEW " title="NEW --- - [bisected regression] piglit spec/glsl-1.50/compiler/incorrect-in-layout-qualifier-repeated-prim.geom" href="https://bugs.freedesktop.org/show_bug.cgi?id=80778#c3">Comment # 3</a> on <a class="bz_bug_link bz_status_NEW " title="NEW --- - [bisected regression] piglit spec/glsl-1.50/compiler/incorrect-in-layout-qualifier-repeated-prim.geom" href="https://bugs.freedesktop.org/show_bug.cgi?id=80778">bug 80778</a> from <a class="email" href="mailto:jljusten@gmail.com" title="Jordan Justen <jljusten@gmail.com>"> Jordan Justen</a> <pre>(In reply to <a href="show_bug.cgi?id=80778#c2">comment #2</a>) > Created <a href="attachment.cgi?id=102112" name="attach_102112" title="Patch to fix the issue">attachment 102112</a> <a href="attachment.cgi?id=102112&action=edit" title="Patch to fix the issue">[details]</a> <a href='page.cgi?id=splinter.html&bug=80778&attachment=102112'>[review]</a> [review] > Patch to fix the issue > > I have reproduced the error. Attached is the patch to fix it. > > Please test it. If it is OK I will send it to the mailing list. Were you able to verify the patch? It is usually easier to reply to email with comments. So, I would suggest just sending it to the list after you have tested it and feel fairly confident in the patch. Nevertheless, my comments on the patch are, how about creating a new local variable? ast_type_qualifier allowed_duplicates_mask; allowed_duplicates_mask.flags.i = ubo_mat_mask.flags.i | ubo_layout_mask.flags.i | ubo_binding_mask.flags.i; if (state->stage == MESA_SHADER_GEOMETRY) allowed_duplicates_mask.flags.i |= stream_layout_mask.flags.i;</pre> </div> <hr> You are receiving this mail because: <ul> <li>You are the QA Contact for the bug.</li> </ul> </body> </html>