<html> <head> <base href="https://bugs.freedesktop.org/" /> </head> <body> <div> <a class="bz_bug_link bz_status_NEW " title="NEW --- - [ILK Bisected]Piglit glean_texCombine fails" href="https://bugs.freedesktop.org/show_bug.cgi?id=83127#c4">Comment # 4</a> on <a class="bz_bug_link bz_status_NEW " title="NEW --- - [ILK Bisected]Piglit glean_texCombine fails" href="https://bugs.freedesktop.org/show_bug.cgi?id=83127">bug 83127</a> from <a class="email" href="mailto:huax.lu@intel.com" title="lu hua <huax.lu@intel.com>"> lu hua</a> <pre>Hi Ken, I retest it on master branch. Test on commit c2c639ecf667b4b7cf17cfe33dfe710432f2c43a(Revert commit) Author: Matt Turner <<a href="mailto:mattst88@gmail.com">mattst88@gmail.com</a>> Date: Thu May 22 09:39:13 2014 -0700 Revert "i965/fs: Change fs_visitor::emit_lrp to use MAC for gen<6" This reverts commit a6860100b87415ab510d0d210cabfeeccebc9a0a. Why this code didn't work in all circumstances is unknown and without a working Ironlake simulator (which uses a different AUB format) we'll probably never know, short of a lot of experimentation, and spending a bunch of time to try to optimize a few instructions on Ironlake is not time well spent. Moreover, for mix(vec4, vec4, vec4) using the accumulator introduces a dependence between the otherwise independent per-component calculations. Not using the accumulator, even if it means an extra instruction per component might be preferable. We don't know, we don't have data, and we don't have the necessary register on Ironlake for shader_time to tell us. Cc: "10.2" <<a href="mailto:mesa-stable@lists.freedesktop.org">mesa-stable@lists.freedesktop.org</a>> Bugzilla: <a class="bz_bug_link bz_status_VERIFIED bz_closed" title="VERIFIED FIXED - [ILK Bisected]Ogles2conform GL_sin_sin_float_frag_xvary.test fails" href="show_bug.cgi?id=77707">https://bugs.freedesktop.org/show_bug.cgi?id=77707</a> Acked-by: Kenneth Graunke <<a href="mailto:kenneth@whitecape.org">kenneth@whitecape.org</a>> [root@x-pk5 piglit]# bin/glean -o -v -v -v -t +texCombine --quick ---------------------------------------------------------------------- GL_EXT_texture_env_combine verification test. We only test a subset of all possible texture env combinations because there's simply too many to exhaustively test them all. Segmentation fault (core dumped) This segfault caused by commit f0f7fb181fc267934a44904da4530f50a698b18d. Revert this commit, then test commit c2c639ecf667b, it still fails. output: ---------------------------------------------------------------------- GL_EXT_texture_env_combine verification test. We only test a subset of all possible texture env combinations because there's simply too many to exhaustively test them all. texCombine: FAIL rgba8, db, z24, s8, win+pmap, id 32 expected 1, 0, 0.25, 0.5, got 1, 0, 0.247059, 0 in Single Texture Test Current combine state: Incoming Fragment RGBA = 0, 0.25, 0.5, 0.75 Texture Unit 0: GL_COMBINE_RGB_EXT = GL_INTERPOLATE_EXT GL_COMBINE_ALPHA_EXT = GL_INTERPOLATE_EXT GL_SOURCE0_RGB_EXT = GL_TEXTURE GL_SOURCE1_RGB_EXT = GL_TEXTURE GL_SOURCE2_RGB_EXT = GL_TEXTURE GL_SOURCE0_ALPHA_EXT = GL_TEXTURE GL_SOURCE1_ALPHA_EXT = GL_TEXTURE GL_SOURCE2_ALPHA_EXT = GL_TEXTURE GL_OPERAND0_RGB_EXT = GL_SRC_COLOR GL_OPERAND1_RGB_EXT = GL_SRC_COLOR GL_OPERAND2_RGB_EXT = GL_SRC_ALPHA GL_OPERAND0_ALPHA_EXT = GL_SRC_ALPHA GL_OPERAND1_ALPHA_EXT = GL_SRC_ALPHA GL_OPERAND2_ALPHA_EXT = GL_SRC_ALPHA GL_RGB_SCALE_EXT = 1 GL_ALPHA_SCALE = 1 Tex Env RGBA = 0.25, 0.5, 0.75, 1 Texture RGBA = 1, 0, 0.25, 0.5 Maybe it has the 2 bad commits between da0c3b02e71c7552ba9324a01a73602094105fcc and c2c639ecf667b4b7cf17cfe33dfe710432f2c43a ?</pre> </div> <hr> You are receiving this mail because: <ul> <li>You are the QA Contact for the bug.</li> </ul> </body> </html>