<html>
<head>
<base href="https://bugs.freedesktop.org/" />
</head>
<body>
<p>
<div>
<b><a class="bz_bug_link
bz_status_NEW "
title="NEW - Invalid read during geometry program build"
href="https://bugs.freedesktop.org/show_bug.cgi?id=82920#c8">Comment # 8</a>
on <a class="bz_bug_link
bz_status_NEW "
title="NEW - Invalid read during geometry program build"
href="https://bugs.freedesktop.org/show_bug.cgi?id=82920">bug 82920</a>
from <span class="vcard"><a class="email" href="mailto:pavol@klacansky.com" title="pavol@klacansky.com">pavol@klacansky.com</a>
</span></b>
<pre>(In reply to Tapani Pälli from <a href="show_bug.cgi?id=82920#c7">comment #7</a>)
<span class="quote">> Created <span class=""><a href="attachment.cgi?id=107763" name="attach_107763" title="fix for valgrind warnings">attachment 107763</a> <a href="attachment.cgi?id=107763&action=edit" title="fix for valgrind warnings">[details]</a></span> <a href='page.cgi?id=splinter.html&bug=82920&attachment=107763'>[review]</a> [review]
> fix for valgrind warnings
>
> This fix removes invalid access to the deleted resource making valgrind
> happy, it does not fix this bug though.</span >
you can simplify one if statement, here is a proof:
((!earlier && !is_gl_identifier(var->name)) || earlier == NULL)
(!A && !B) || !(A != NULL)
(!A && !B) || !A
(!A || !A) && (!A || !B)
true && (!A || !B)
!A || !B
hence
(!earlier || !is_gl_identifier(var->name))</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the QA Contact for the bug.</li>
</ul>
</body>
</html>