<html>
<head>
<base href="https://bugs.freedesktop.org/" />
</head>
<body>
<p>
<div>
<b><a class="bz_bug_link
bz_status_ASSIGNED "
title="ASSIGNED - [SNB bisected]Webglc conformance/textures/texture-size-limit.html fails"
href="https://bugs.freedesktop.org/show_bug.cgi?id=78770#c10">Comment # 10</a>
on <a class="bz_bug_link
bz_status_ASSIGNED "
title="ASSIGNED - [SNB bisected]Webglc conformance/textures/texture-size-limit.html fails"
href="https://bugs.freedesktop.org/show_bug.cgi?id=78770">bug 78770</a>
from <span class="vcard"><a class="email" href="mailto:huax.lu@intel.com" title="lu hua <huax.lu@intel.com>"> <span class="fn">lu hua</span></a>
</span></b>
<pre>(In reply to Chad Versace from <a href="show_bug.cgi?id=78770#c9">comment #9</a>)
<span class="quote">> Created <span class=""><a href="attachment.cgi?id=108863" name="attach_108863" title="work-in-progress fix">attachment 108863</a> <a href="attachment.cgi?id=108863&action=edit" title="work-in-progress fix">[details]</a></span> <a href='page.cgi?id=splinter.html&bug=78770&attachment=108863'>[review]</a> [review]
> work-in-progress fix
>
> Attached patch fixes the bug. intel_miptree_map_gtt() is not 64-bit safe.
>
> Before submitting the patch to mesa-dev, I need to do a full regression run
> on Piglit. Also, I'd like to make a more general fix.</span >
I test this patch, it still fails.
diff --git a/src/mesa/drivers/dri/i965/intel_mipmap_tree.c
b/src/mesa/drivers/dri/i965/intel_mipmap_tree.c
index 8fda25d..511d36b 100644
--- a/src/mesa/drivers/dri/i965/intel_mipmap_tree.c
+++ b/src/mesa/drivers/dri/i965/intel_mipmap_tree.c
@@ -1769,7 +1769,13 @@ intel_miptree_map_gtt(struct brw_context *brw,
y += image_y;
map->stride = mt->pitch;
- map->ptr = base + y * map->stride + x * mt->cpp;
+
+ /* TODO(chadv): Fix this correctly
+ *
+ * Prevent WebGL Conformance test texture-size-limit from segfaulting on
Chrome.
+ * See [<a class="bz_bug_link
bz_status_ASSIGNED "
title="ASSIGNED - [SNB bisected]Webglc conformance/textures/texture-size-limit.html fails"
href="show_bug.cgi?id=78770">https://bugs.freedesktop.org/show_bug.cgi?id=78770</a>].
+ */
+ map->ptr = base + (intptr_t) y * (intptr_t) map->stride + (intptr_t) x *
(intptr_t) mt->cpp;
}
DBG("%s: %d,%d %dx%d from mt %p (%s) %d,%d = %p/%d\n", __FUNCTION__,</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the QA Contact for the bug.</li>
</ul>
</body>
</html>