<html>
<head>
<base href="https://bugs.freedesktop.org/" />
</head>
<body>
<p>
<div>
<b><a class="bz_bug_link
bz_status_ASSIGNED "
title="ASSIGNED - [SNB+ Bisected]Ogles3conform ES3-CTS.gtf.GL3Tests.packed_pixels.packed_pixels core dumped"
href="https://bugs.freedesktop.org/show_bug.cgi?id=88385#c8">Comment # 8</a>
on <a class="bz_bug_link
bz_status_ASSIGNED "
title="ASSIGNED - [SNB+ Bisected]Ogles3conform ES3-CTS.gtf.GL3Tests.packed_pixels.packed_pixels core dumped"
href="https://bugs.freedesktop.org/show_bug.cgi?id=88385">bug 88385</a>
from <span class="vcard"><a class="email" href="mailto:itoral@igalia.com" title="Iago Toral <itoral@igalia.com>"> <span class="fn">Iago Toral</span></a>
</span></b>
<pre>Comment on <span class=""><a href="attachment.cgi?id=112332" name="attach_112332" title="patch to fix the issue">attachment 112332</a> <a href="attachment.cgi?id=112332&action=edit" title="patch to fix the issue">[details]</a></span> <a href='page.cgi?id=splinter.html&bug=88385&attachment=112332'>[review]</a>
patch to fix the issue
Review of <span class=""><a href="attachment.cgi?id=112332" name="attach_112332" title="patch to fix the issue">attachment 112332</a> <a href="attachment.cgi?id=112332&action=edit" title="patch to fix the issue">[details]</a></span> <a href='page.cgi?id=splinter.html&bug=88385&attachment=112332'>[review]</a>:
-----------------------------------------------------------------
::: src/mesa/main/formats.c
@@ +972,4 @@
<span class="quote">> return;
>
> case MESA_FORMAT_B10G10R10A2_UNORM:
> + case MESA_FORMAT_R10G10B10X2_UNORM:</span >
There is a "case MESA_FORMAT_B10G10R10X2_UNORM" a bit below, it is the same
code, but maybe it makes more sense to move the "case
MESA_FORMAT_R10G10B10X2_UNORM" down there so we keep formats with X bits
together.
@@ +1727,5 @@
<span class="quote">> case MESA_FORMAT_A2R10G10B10_UNORM:
> return format == GL_BGRA && type == GL_UNSIGNED_INT_10_10_10_2;
>
> + case MESA_FORMAT_R10G10B10X2_UNORM:
> + return format == GL_RGB && type == GL_UNSIGNED_INT_2_10_10_10_REV;</span >
I think this might be wrong: looking at other formats with X bits in this same
function, they all return FALSE...</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the QA Contact for the bug.</li>
</ul>
</body>
</html>