<html>
<head>
<base href="https://bugs.freedesktop.org/" />
</head>
<body><span class="vcard"><a class="email" href="mailto:cworth@cworth.org" title="Carl Worth <cworth@cworth.org>"> <span class="fn">Carl Worth</span></a>
</span> changed
<a class="bz_bug_link
bz_status_NEW "
title="NEW - [radeonsi] [bisected] reaction-game crashes with GLSL compiler error"
href="https://bugs.freedesktop.org/show_bug.cgi?id=89064">bug 89064</a>
<br>
<table border="1" cellspacing="0" cellpadding="8">
<tr>
<th>What</th>
<th>Removed</th>
<th>Added</th>
</tr>
<tr>
<td style="text-align:right;">Assignee</td>
<td>idr@freedesktop.org
</td>
<td>cworth@cworth.org
</td>
</tr></table>
<p>
<div>
<b><a class="bz_bug_link
bz_status_NEW "
title="NEW - [radeonsi] [bisected] reaction-game crashes with GLSL compiler error"
href="https://bugs.freedesktop.org/show_bug.cgi?id=89064#c5">Comment # 5</a>
on <a class="bz_bug_link
bz_status_NEW "
title="NEW - [radeonsi] [bisected] reaction-game crashes with GLSL compiler error"
href="https://bugs.freedesktop.org/show_bug.cgi?id=89064">bug 89064</a>
from <span class="vcard"><a class="email" href="mailto:cworth@cworth.org" title="Carl Worth <cworth@cworth.org>"> <span class="fn">Carl Worth</span></a>
</span></b>
<pre>Actually, looking closer at the "v2" portion of my commit message in
the proposed patch:
v2: Instead of emitting the error as soon as the illegal
character is lexed, we instead emit an ILLEGAL token to the
parser. This allows the parser to allow the character as part
of the replacement list of a macro, (since these are specified
to allow any character). However, if such a macro is actually
instantiated, the parser will emit an error when it goes to
print the illegal character as part of the preprocessed
output.
It would appear that with this patch applied, even a version of
Reactive Quake with the bug would still work fine, (since, from what I
recall, the bogusly-defined macro is never instantiated).
So, yes, I'll see about getting this patch pushed out as soon as
possible.
-Carl</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the QA Contact for the bug.</li>
</ul>
</body>
</html>