<html> <head> <base href="https://bugs.freedesktop.org/" /> </head> <body> <div> <a class="bz_bug_link bz_status_ASSIGNED " title="ASSIGNED - [BDW/BSW Bisected]Piglit spec_ARB_shader_atomic_counters_array-indexing fails" href="https://bugs.freedesktop.org/show_bug.cgi?id=87258#c7">Comment # 7</a> on <a class="bz_bug_link bz_status_ASSIGNED " title="ASSIGNED - [BDW/BSW Bisected]Piglit spec_ARB_shader_atomic_counters_array-indexing fails" href="https://bugs.freedesktop.org/show_bug.cgi?id=87258">bug 87258</a> from <a class="email" href="mailto:kenneth@whitecape.org" title="Kenneth Graunke <kenneth@whitecape.org>"> Kenneth Graunke</a> <pre>(In reply to Ben Widawsky from <a href="show_bug.cgi?id=87258#c5">comment #5</a>) > Created <a href="attachment.cgi?id=113516" name="attach_113516" title="VS does the enables differently than ps">attachment 113516</a> <a href="attachment.cgi?id=113516&action=edit" title="VS does the enables differently than ps">[details]</a> <a href='page.cgi?id=splinter.html&bug=87258&attachment=113516'>[review]</a> [review] > VS does the enables differently than ps > > Please test Hey, nice catch, Ben! I didn't spot this when I was looking at it a while ago. Using the CE register makes a lot of sense. A couple of suggestions on the patch: 1. Could you put a /* HSW+ */ comment after the #define BRW_ARF_CE 0x40? 2. Could we put the MESA_SHADER_VERTEX case before the uses_kill case, just to keep the two pixel shader cases together? 3. I think vstride should be 0, not 4...I honestly have no idea why brw_ip_reg is the way it is, but it's been that way forever. We should probably also drop the NOTE! and ? comments. Assuming the vstride change actually works, and you're good with those suggestions, feel free to put my R-b on it.</pre> </div> <hr> You are receiving this mail because: <ul> <li>You are the QA Contact for the bug.</li> </ul> </body> </html>