<html> <head> <base href="https://bugs.freedesktop.org/" /> </head> <body> <div> <a class="bz_bug_link bz_status_NEW " title="NEW - UE4Editor crash after load project" href="https://bugs.freedesktop.org/show_bug.cgi?id=89416#c5">Comment # 5</a> on <a class="bz_bug_link bz_status_NEW " title="NEW - UE4Editor crash after load project" href="https://bugs.freedesktop.org/show_bug.cgi?id=89416">bug 89416</a> from <a class="email" href="mailto:jason@jlekstrand.net" title="Jason Ekstrand <jason@jlekstrand.net>"> Jason Ekstrand</a> <pre>(In reply to Uriy Zhuravlev from <a href="show_bug.cgi?id=89416#c4">comment #4</a>) > Ok, alignment... maybe I can fix it. Uriy, The problem here is that the code originally assumed that the destination would always be nicely aligned but the source may not. When rgba8_copy function started getting used for texture *download* via ReadPixels and GetTexImage the assumption now fails and it is the source that is aligned and not the destination. To fix this we need to do one of two things. Either a) make the rgba8_copy function use unaligned reads (which would b slower) or b) make two versions of the rgba8_copy function: one for upload and one for download. I think option b) is best but if we're going to do that then we need to add a flag to intel_get_memcpy to make sure it returns the correct one and then thread it through the tiled_to_linear_faster functions as well.</pre> </div> <hr> You are receiving this mail because: <ul> <li>You are the QA Contact for the bug.</li> </ul> </body> </html>