<html>
<head>
<base href="https://bugs.freedesktop.org/" />
</head>
<body>
<p>
<div>
<b><a class="bz_bug_link
bz_status_NEW "
title="NEW - UE4Editor crash after load project"
href="https://bugs.freedesktop.org/show_bug.cgi?id=89416#c7">Comment # 7</a>
on <a class="bz_bug_link
bz_status_NEW "
title="NEW - UE4Editor crash after load project"
href="https://bugs.freedesktop.org/show_bug.cgi?id=89416">bug 89416</a>
from <span class="vcard"><a class="email" href="mailto:jason@jlekstrand.net" title="Jason Ekstrand <jason@jlekstrand.net>"> <span class="fn">Jason Ekstrand</span></a>
</span></b>
<pre>(In reply to Matt Turner from <a href="show_bug.cgi?id=89416#c6">comment #6</a>)
<span class="quote">> (In reply to Jason Ekstrand from <a href="show_bug.cgi?id=89416#c5">comment #5</a>)
> > (In reply to Uriy Zhuravlev from <a href="show_bug.cgi?id=89416#c4">comment #4</a>)
> > > Ok, alignment... maybe I can fix it.
> >
> > Uriy,
> > The problem here is that the code originally assumed that the destination
> > would always be nicely aligned but the source may not. When rgba8_copy
> > function started getting used for texture *download* via ReadPixels and
> > GetTexImage the assumption now fails and it is the source that is aligned
> > and not the destination. To fix this we need to do one of two things.
> > Either a) make the rgba8_copy function use unaligned reads (which would b
> > slower) or b) make two versions of the rgba8_copy function: one for upload
> > and one for download.
>
> Basically, this all stems from the fact that there's no guarantee that the
> pointer given to glReadPixels/glGetTexImage is suitably aligned?
>
> Do you have time to fix this before the release on Friday? Trying to figure
> if I need to work on this.</span >
I think it would probably be more efficient if you did. The above should be
enough of a brain dump on what needs to happen in the tiled_memcpy paths. The
rest is writing suitable mmx code and you probably know more about that than I
do. TBH: I'd probably be asking you on IRC what instructions to use anyway.
If you don't want to bother with threading it through the tiled_memcpy code, I
can do that part quick enough.</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the QA Contact for the bug.</li>
</ul>
</body>
</html>